Skip to content

CCM-14566: Add FHIR validation to mesh-download#276

Open
simonlabarere wants to merge 2 commits intomainfrom
feature/CCM-14566_validate_fhir_request
Open

CCM-14566: Add FHIR validation to mesh-download#276
simonlabarere wants to merge 2 commits intomainfrom
feature/CCM-14566_validate_fhir_request

Conversation

@simonlabarere
Copy link
Copy Markdown
Contributor

@simonlabarere simonlabarere commented Apr 7, 2026

Description

  • Add new mappings for failure codes DL_CLIV_004 and DL_CLIV_005
  • Update mesh.inbox.message.invalid event data to include an optional messageReference
  • Update mesh-download lambda to pull schema dependency validation from https://github.com/NHSDigital/nhs-notify-digital-letters-onboarding
  • Update mesh-download lambda to publish a mesh.inbox.message.invalid when the PDM FHIR resource is invalid

Context

We want to fail invalid FHIR resources early in order to notify trusts.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@simonlabarere simonlabarere requested review from a team as code owners April 7, 2026 10:03
idna>=3.7
requests>=2.32.0
pyopenssl>=24.2.1
nhs-notify-digital-letters-onboarding @ git+https://github.com/NHSDigital/nhs-notify-digital-letters-onboarding@75362ff36814a0b355f95ad8b6834e400c49c161
Copy link
Copy Markdown
Contributor Author

@simonlabarere simonlabarere Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be replaced with a tag once it's available.

@simonlabarere simonlabarere added the enhancement New feature or request label Apr 7, 2026
@simonlabarere simonlabarere force-pushed the feature/CCM-14566_validate_fhir_request branch 2 times, most recently from 20f2698 to e5d2941 Compare April 7, 2026 10:26
@simonlabarere simonlabarere force-pushed the feature/CCM-14566_validate_fhir_request branch from eea1557 to 191c71e Compare April 7, 2026 13:18
@gareth-allan gareth-allan self-assigned this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants